Use only one button for Set featured image and image preview. #14415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Focus] Accessibility (a11y)
jorgefilipecosta
approved these changes
Mar 14, 2019
| title={ postLabel.featured_image || DEFAULT_FEATURE_IMAGE_LABEL } | ||
| onSelect={ onUpdateImage } | ||
| allowedTypes={ ALLOWED_MEDIA_TYPES } | ||
| modalClass={ ! featuredImageId ? 'editor-post-featured-image__media-modal' : 'editor-post-featured-image__media-modal' } |
There was a problem hiding this comment.
Both classes are the same -- I think we can just use modalClass="editor-post-featured-image__media-modal".
jorgefilipecosta
deleted the
update/featured-image-refactor-buttons-avoid-focus-loss
branch
|
Thanks @jorgefilipecosta ! Didn't have time to look into the class thing today, sorry. |
This was referenced Mar 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 20, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 20, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the featured image buttons to avoid a focus loss.
The "Set featured image" and the image preview are both buttons. Actually, they're two
MediaUploadCheckcomponents: very similar, only the props and children are different.By using only one
MediaUploadCheckand updating props and children, the reference to the "opener" DOM element is not lost and the Media Modal is able to move focus back properly when it closes.To test:
Fixes #14414